SUSE: CVE-2024-26935: SUSE Linux Security Advisory
Description
In the Linux kernel, the following vulnerability has been resolved: scsi: core: Fix unremoved procfs host directory regression Commit fc663711b944 ("scsi: core: Remove the /proc/scsi/${proc_name} directory earlier") fixed a bug related to modules loading/unloading, by adding a call to scsi_proc_hostdir_rm() on scsi_remove_host(). But that led to a potential duplicate call to the hostdir_rm() routine, since it's also called from scsi_host_dev_release(). That triggered a regression report, which was then fixed by commit be03df3d4bfe ("scsi: core: Fix a procfs host directory removal regression"). The fix just dropped the hostdir_rm() call from dev_release(). But it happens that this proc directory is created on scsi_host_alloc(), and that function "pairs" with scsi_host_dev_release(), while scsi_remove_host() pairs with scsi_add_host(). In other words, it seems the reason for removing the proc directory on dev_release() was meant to cover cases in which a SCSI host structure was allocated, but the call to scsi_add_host() didn't happen. And that pattern happens to exist in some error paths, for example. Syzkaller causes that by using USB raw gadget device, error'ing on usb-storage driver, at usb_stor_probe2(). By checking that path, we can see that the BadDevice label leads to a scsi_host_put() after a SCSI host allocation, but there's no call to scsi_add_host() in such path. That leads to messages like this in dmesg (and a leak of the SCSI host proc structure): usb-storage 4-1:87.51: USB Mass Storage device detected proc_dir_entry 'scsi/usb-storage' already registered WARNING: CPU: 1 PID: 3519 at fs/proc/generic.c:377 proc_register+0x347/0x4e0 fs/proc/generic.c:376 The proper fix seems to still call scsi_proc_hostdir_rm() on dev_release(), but guard that with the state check for SHOST_CREATED; there is even a comment in scsi_host_dev_release() detailing that: such conditional is meant for cases where the SCSI host was allocated but there was no calls to {add,remove}_host(), like the usb-storage case. This is what we propose here and with that, the error path of usb-storage does not trigger the warning anymore.
Solution(s)
- suse-upgrade-cluster-md-kmp-64kb
- suse-upgrade-cluster-md-kmp-azure
- suse-upgrade-cluster-md-kmp-default
- suse-upgrade-cluster-md-kmp-rt
- suse-upgrade-dlm-kmp-64kb
- suse-upgrade-dlm-kmp-azure
- suse-upgrade-dlm-kmp-default
- suse-upgrade-dlm-kmp-rt
- suse-upgrade-dtb-allwinner
- suse-upgrade-dtb-altera
- suse-upgrade-dtb-amazon
- suse-upgrade-dtb-amd
- suse-upgrade-dtb-amlogic
- suse-upgrade-dtb-apm
- suse-upgrade-dtb-apple
- suse-upgrade-dtb-arm
- suse-upgrade-dtb-broadcom
- suse-upgrade-dtb-cavium
- suse-upgrade-dtb-exynos
- suse-upgrade-dtb-freescale
- suse-upgrade-dtb-hisilicon
- suse-upgrade-dtb-lg
- suse-upgrade-dtb-marvell
- suse-upgrade-dtb-mediatek
- suse-upgrade-dtb-nvidia
- suse-upgrade-dtb-qcom
- suse-upgrade-dtb-renesas
- suse-upgrade-dtb-rockchip
- suse-upgrade-dtb-socionext
- suse-upgrade-dtb-sprd
- suse-upgrade-dtb-xilinx
- suse-upgrade-gfs2-kmp-64kb
- suse-upgrade-gfs2-kmp-azure
- suse-upgrade-gfs2-kmp-default
- suse-upgrade-gfs2-kmp-rt
- suse-upgrade-kernel-64kb
- suse-upgrade-kernel-64kb-devel
- suse-upgrade-kernel-64kb-extra
- suse-upgrade-kernel-64kb-livepatch-devel
- suse-upgrade-kernel-64kb-optional
- suse-upgrade-kernel-azure
- suse-upgrade-kernel-azure-devel
- suse-upgrade-kernel-azure-extra
- suse-upgrade-kernel-azure-livepatch-devel
- suse-upgrade-kernel-azure-optional
- suse-upgrade-kernel-azure-vdso
- suse-upgrade-kernel-debug
- suse-upgrade-kernel-debug-devel
- suse-upgrade-kernel-debug-livepatch-devel
- suse-upgrade-kernel-debug-vdso
- suse-upgrade-kernel-default
- suse-upgrade-kernel-default-base
- suse-upgrade-kernel-default-base-rebuild
- suse-upgrade-kernel-default-devel
- suse-upgrade-kernel-default-extra
- suse-upgrade-kernel-default-livepatch
- suse-upgrade-kernel-default-livepatch-devel
- suse-upgrade-kernel-default-optional
- suse-upgrade-kernel-default-vdso
- suse-upgrade-kernel-devel
- suse-upgrade-kernel-devel-azure
- suse-upgrade-kernel-devel-rt
- suse-upgrade-kernel-docs
- suse-upgrade-kernel-docs-html
- suse-upgrade-kernel-kvmsmall
- suse-upgrade-kernel-kvmsmall-devel
- suse-upgrade-kernel-kvmsmall-livepatch-devel
- suse-upgrade-kernel-kvmsmall-vdso
- suse-upgrade-kernel-macros
- suse-upgrade-kernel-obs-build
- suse-upgrade-kernel-obs-qa
- suse-upgrade-kernel-rt
- suse-upgrade-kernel-rt-devel
- suse-upgrade-kernel-rt-extra
- suse-upgrade-kernel-rt-livepatch
- suse-upgrade-kernel-rt-livepatch-devel
- suse-upgrade-kernel-rt-optional
- suse-upgrade-kernel-rt-vdso
- suse-upgrade-kernel-rt_debug
- suse-upgrade-kernel-rt_debug-devel
- suse-upgrade-kernel-rt_debug-livepatch-devel
- suse-upgrade-kernel-rt_debug-vdso
- suse-upgrade-kernel-source
- suse-upgrade-kernel-source-azure
- suse-upgrade-kernel-source-rt
- suse-upgrade-kernel-source-vanilla
- suse-upgrade-kernel-syms
- suse-upgrade-kernel-syms-azure
- suse-upgrade-kernel-syms-rt
- suse-upgrade-kernel-zfcpdump
- suse-upgrade-kselftests-kmp-64kb
- suse-upgrade-kselftests-kmp-azure
- suse-upgrade-kselftests-kmp-default
- suse-upgrade-kselftests-kmp-rt
- suse-upgrade-ocfs2-kmp-64kb
- suse-upgrade-ocfs2-kmp-azure
- suse-upgrade-ocfs2-kmp-default
- suse-upgrade-ocfs2-kmp-rt
- suse-upgrade-reiserfs-kmp-64kb
- suse-upgrade-reiserfs-kmp-azure
- suse-upgrade-reiserfs-kmp-default
- suse-upgrade-reiserfs-kmp-rt
- Lightweight Endpoint Agent
- Live Dashboards
- Real Risk Prioritization
- IT-Integrated Remediation Projects
- Cloud, Virtual, and Container Assessment
- Integrated Threat Feeds
- Easy-to-Use RESTful API
- Automation-Assisted Patching
- Automated Containment
With Rapid7 live dashboards, I have a clear view of all the assets on my network, which ones can be exploited, and what I need to do in order to reduce the risk in my environment in real-time. No other tool gives us that kind of value and insight.
– Scott Cheney, Manager of Information Security, Sierra View Medical Center