Ubuntu: (Multiple Advisories) (CVE-2023-52587): Linux kernel (OEM) vulnerabilities
Description
In the Linux kernel, the following vulnerability has been resolved: IB/ipoib: Fix mcast list locking Releasing the `priv->lock` while iterating the `priv->multicast_list` in `ipoib_mcast_join_task()` opens a window for `ipoib_mcast_dev_flush()` to remove the items while in the middle of iteration. If the mcast is removed while the lock was dropped, the for loop spins forever resulting in a hard lockup (as was reported on RHEL 4.18.0-372.75.1.el8_6 kernel): Task A (kworker/u72:2 below) | Task B (kworker/u72:0 below) -----------------------------------+----------------------------------- ipoib_mcast_join_task(work) | ipoib_ib_dev_flush_light(work) spin_lock_irq(&priv->lock) | __ipoib_ib_dev_flush(priv, ...) list_for_each_entry(mcast, | ipoib_mcast_dev_flush(dev = priv->dev) &priv->multicast_list, list) | ipoib_mcast_join(dev, mcast) | spin_unlock_irq(&priv->lock) | | spin_lock_irqsave(&priv->lock, flags) | list_for_each_entry_safe(mcast, tmcast, | &priv->multicast_list, list) | list_del(&mcast->list); | list_add_tail(&mcast->list, &remove_list) | spin_unlock_irqrestore(&priv->lock, flags) spin_lock_irq(&priv->lock) | | ipoib_mcast_remove_list(&remove_list) (Here, `mcast` is no longer on the | list_for_each_entry_safe(mcast, tmcast, `priv->multicast_list` and we keep | remove_list, list) spinning on the `remove_list` of | >>> wait_for_completion(&mcast->done) the other thread which is blocked | and the list is still valid on | it's stack.) Fix this by keeping the lock held and changing to GFP_ATOMIC to prevent eventual sleeps. Unfortunately we could not reproduce the lockup and confirm this fix but based on the code review I think this fix should address such lockups. crash> bc 31 PID: 747 TASK: ff1c6a1a007e8000 CPU: 31 COMMAND: "kworker/u72:2" -- [exception RIP: ipoib_mcast_join_task+0x1b1] RIP: ffffffffc0944ac1 RSP: ff646f199a8c7e00 RFLAGS: 00000002 RAX: 0000000000000000 RBX: ff1c6a1a04dc82f8 RCX: 0000000000000000 work (&priv->mcast_task{,.work}) RDX: ff1c6a192d60ac68 RSI: 0000000000000286 RDI: ff1c6a1a04dc8000 &mcast->list RBP: ff646f199a8c7e90 R8: ff1c699980019420 R9: ff1c6a1920c9a000 R10: ff646f199a8c7e00 R11: ff1c6a191a7d9800 R12: ff1c6a192d60ac00 mcast R13: ff1c6a1d82200000 R14: ff1c6a1a04dc8000 R15: ff1c6a1a04dc82d8 dev priv (&priv->lock) &priv->multicast_list (aka head) ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 --- <NMI exception stack> --- #5 [ff646f199a8c7e00] ipoib_mcast_join_task+0x1b1 at ffffffffc0944ac1 [ib_ipoib] #6 [ff646f199a8c7e98] process_one_work+0x1a7 at ffffffff9bf10967 crash> rx ff646f199a8c7e68 ff646f199a8c7e68: ff1c6a1a04dc82f8 <<< work = &priv->mcast_task.work crash> list -hO ipoib_dev_priv.multicast_list ff1c6a1a04dc8000 (empty) crash> ipoib_dev_priv.mcast_task.work.func,mcast_mutex.owner.counter ff1c6a1a04dc8000 mcast_task.work.func = 0xffffffffc0944910 <ipoib_mcast_join_task>, mcast_mutex.owner.counter = 0xff1c69998efec000 crash> b 8 PID: 8 TASK: ff1c69998efec000 CPU: 33 COMMAND: "kworker/u72:0" -- #3 [ff646f1980153d50] wait_for_completion+0x96 at ffffffff9c7d7646 #4 [ff646f1980153d90] ipoib_mcast_remove_list+0x56 at ffffffffc0944dc6 [ib_ipoib] #5 [ff646f1980153de8] ipoib_mcast_dev_flush+0x1a7 at ffffffffc09455a7 [ib_ipoib] #6 [ff646f1980153e58] __ipoib_ib_dev_flush+0x1a4 at ffffffffc09431a4 [ib_ipoib] #7 [ff ---truncated---
Solution(s)
- ubuntu-upgrade-linux-image-5-15-0-1044-gkeop
- ubuntu-upgrade-linux-image-5-15-0-1054-ibm
- ubuntu-upgrade-linux-image-5-15-0-1054-nvidia
- ubuntu-upgrade-linux-image-5-15-0-1054-nvidia-lowlatency
- ubuntu-upgrade-linux-image-5-15-0-1054-raspi
- ubuntu-upgrade-linux-image-5-15-0-1057-intel-iotg
- ubuntu-upgrade-linux-image-5-15-0-1058-gke
- ubuntu-upgrade-linux-image-5-15-0-1058-intel-iotg
- ubuntu-upgrade-linux-image-5-15-0-1058-kvm
- ubuntu-upgrade-linux-image-5-15-0-1059-gcp
- ubuntu-upgrade-linux-image-5-15-0-1059-oracle
- ubuntu-upgrade-linux-image-5-15-0-106-generic
- ubuntu-upgrade-linux-image-5-15-0-106-generic-64k
- ubuntu-upgrade-linux-image-5-15-0-106-generic-lpae
- ubuntu-upgrade-linux-image-5-15-0-106-lowlatency
- ubuntu-upgrade-linux-image-5-15-0-106-lowlatency-64k
- ubuntu-upgrade-linux-image-5-15-0-1061-aws
- ubuntu-upgrade-linux-image-5-15-0-1063-azure
- ubuntu-upgrade-linux-image-5-15-0-1063-azure-fde
- ubuntu-upgrade-linux-image-5-4-0-1036-iot
- ubuntu-upgrade-linux-image-5-4-0-1043-xilinx-zynqmp
- ubuntu-upgrade-linux-image-5-4-0-1071-ibm
- ubuntu-upgrade-linux-image-5-4-0-1084-bluefield
- ubuntu-upgrade-linux-image-5-4-0-1091-gkeop
- ubuntu-upgrade-linux-image-5-4-0-1108-raspi
- ubuntu-upgrade-linux-image-5-4-0-1112-kvm
- ubuntu-upgrade-linux-image-5-4-0-1123-oracle
- ubuntu-upgrade-linux-image-5-4-0-1124-aws
- ubuntu-upgrade-linux-image-5-4-0-1128-gcp
- ubuntu-upgrade-linux-image-5-4-0-1129-azure
- ubuntu-upgrade-linux-image-5-4-0-181-generic
- ubuntu-upgrade-linux-image-5-4-0-181-generic-lpae
- ubuntu-upgrade-linux-image-5-4-0-181-lowlatency
- ubuntu-upgrade-linux-image-6-1-0-1035-oem
- ubuntu-upgrade-linux-image-6-5-0-1015-starfive
- ubuntu-upgrade-linux-image-6-5-0-1017-laptop
- ubuntu-upgrade-linux-image-6-5-0-1018-raspi
- ubuntu-upgrade-linux-image-6-5-0-1021-aws
- ubuntu-upgrade-linux-image-6-5-0-1021-nvidia
- ubuntu-upgrade-linux-image-6-5-0-1021-nvidia-64k
- ubuntu-upgrade-linux-image-6-5-0-1022-azure
- ubuntu-upgrade-linux-image-6-5-0-1022-azure-fde
- ubuntu-upgrade-linux-image-6-5-0-1022-gcp
- ubuntu-upgrade-linux-image-6-5-0-1022-oem
- ubuntu-upgrade-linux-image-6-5-0-1024-oem
- ubuntu-upgrade-linux-image-6-5-0-1024-oracle
- ubuntu-upgrade-linux-image-6-5-0-1024-oracle-64k
- ubuntu-upgrade-linux-image-6-5-0-41-generic
- ubuntu-upgrade-linux-image-6-5-0-41-generic-64k
- ubuntu-upgrade-linux-image-6-5-0-41-lowlatency
- ubuntu-upgrade-linux-image-6-5-0-41-lowlatency-64k
- ubuntu-upgrade-linux-image-aws
- ubuntu-upgrade-linux-image-aws-lts-20-04
- ubuntu-upgrade-linux-image-aws-lts-22-04
- ubuntu-upgrade-linux-image-azure
- ubuntu-upgrade-linux-image-azure-cvm
- ubuntu-upgrade-linux-image-azure-fde
- ubuntu-upgrade-linux-image-azure-fde-lts-22-04
- ubuntu-upgrade-linux-image-azure-lts-20-04
- ubuntu-upgrade-linux-image-azure-lts-22-04
- ubuntu-upgrade-linux-image-bluefield
- ubuntu-upgrade-linux-image-gcp
- ubuntu-upgrade-linux-image-gcp-lts-20-04
- ubuntu-upgrade-linux-image-gcp-lts-22-04
- ubuntu-upgrade-linux-image-generic
- ubuntu-upgrade-linux-image-generic-64k
- ubuntu-upgrade-linux-image-generic-64k-hwe-20-04
- ubuntu-upgrade-linux-image-generic-64k-hwe-22-04
- ubuntu-upgrade-linux-image-generic-hwe-18-04
- ubuntu-upgrade-linux-image-generic-hwe-20-04
- ubuntu-upgrade-linux-image-generic-hwe-22-04
- ubuntu-upgrade-linux-image-generic-lpae
- ubuntu-upgrade-linux-image-generic-lpae-hwe-20-04
- ubuntu-upgrade-linux-image-gke
- ubuntu-upgrade-linux-image-gke-5-15
- ubuntu-upgrade-linux-image-gkeop
- ubuntu-upgrade-linux-image-gkeop-5-15
- ubuntu-upgrade-linux-image-gkeop-5-4
- ubuntu-upgrade-linux-image-ibm
- ubuntu-upgrade-linux-image-ibm-lts-20-04
- ubuntu-upgrade-linux-image-intel
- ubuntu-upgrade-linux-image-intel-iotg
- ubuntu-upgrade-linux-image-kvm
- ubuntu-upgrade-linux-image-laptop-23-10
- ubuntu-upgrade-linux-image-lowlatency
- ubuntu-upgrade-linux-image-lowlatency-64k
- ubuntu-upgrade-linux-image-lowlatency-64k-hwe-20-04
- ubuntu-upgrade-linux-image-lowlatency-64k-hwe-22-04
- ubuntu-upgrade-linux-image-lowlatency-hwe-18-04
- ubuntu-upgrade-linux-image-lowlatency-hwe-20-04
- ubuntu-upgrade-linux-image-lowlatency-hwe-22-04
- ubuntu-upgrade-linux-image-nvidia
- ubuntu-upgrade-linux-image-nvidia-6-5
- ubuntu-upgrade-linux-image-nvidia-64k-6-5
- ubuntu-upgrade-linux-image-nvidia-64k-hwe-22-04
- ubuntu-upgrade-linux-image-nvidia-hwe-22-04
- ubuntu-upgrade-linux-image-nvidia-lowlatency
- ubuntu-upgrade-linux-image-oem
- ubuntu-upgrade-linux-image-oem-20-04
- ubuntu-upgrade-linux-image-oem-20-04b
- ubuntu-upgrade-linux-image-oem-20-04c
- ubuntu-upgrade-linux-image-oem-20-04d
- ubuntu-upgrade-linux-image-oem-22-04
- ubuntu-upgrade-linux-image-oem-22-04a
- ubuntu-upgrade-linux-image-oem-22-04b
- ubuntu-upgrade-linux-image-oem-22-04c
- ubuntu-upgrade-linux-image-oem-22-04d
- ubuntu-upgrade-linux-image-oem-osp1
- ubuntu-upgrade-linux-image-oracle
- ubuntu-upgrade-linux-image-oracle-64k
- ubuntu-upgrade-linux-image-oracle-lts-20-04
- ubuntu-upgrade-linux-image-oracle-lts-22-04
- ubuntu-upgrade-linux-image-raspi
- ubuntu-upgrade-linux-image-raspi-hwe-18-04
- ubuntu-upgrade-linux-image-raspi-nolpae
- ubuntu-upgrade-linux-image-raspi2
- ubuntu-upgrade-linux-image-snapdragon-hwe-18-04
- ubuntu-upgrade-linux-image-starfive
- ubuntu-upgrade-linux-image-virtual
- ubuntu-upgrade-linux-image-virtual-hwe-18-04
- ubuntu-upgrade-linux-image-virtual-hwe-20-04
- ubuntu-upgrade-linux-image-virtual-hwe-22-04
- ubuntu-upgrade-linux-image-xilinx-zynqmp
- Lightweight Endpoint Agent
- Live Dashboards
- Real Risk Prioritization
- IT-Integrated Remediation Projects
- Cloud, Virtual, and Container Assessment
- Integrated Threat Feeds
- Easy-to-Use RESTful API
- Automation-Assisted Patching
- Automated Containment
With Rapid7 live dashboards, I have a clear view of all the assets on my network, which ones can be exploited, and what I need to do in order to reduce the risk in my environment in real-time. No other tool gives us that kind of value and insight.
– Scott Cheney, Manager of Information Security, Sierra View Medical Center